Skip to content

[%pS migration] Use %pS in ext/xmlreader - #23174

Draft
DanielEScherzer wants to merge 1 commit into
php:masterfrom
DanielEScherzer:ps-migration-ext-xmlreader
Draft

[%pS migration] Use %pS in ext/xmlreader#23174
DanielEScherzer wants to merge 1 commit into
php:masterfrom
DanielEScherzer:ps-migration-ext-xmlreader

Conversation

@DanielEScherzer

Copy link
Copy Markdown
Member

No description provided.

@DanielEScherzer

Copy link
Copy Markdown
Member Author

Usefulness analysis:

  • in xmlreader_write_property() the class name can contain null bytes (https://3v4l.org/EiAoh#v) so %pS is needed; property name cannot contain null bytes because the only values are those present in xmlreader_prop_handlers and none of those have null bytes, but is updated for consistency
  • in XMLReader::expand() the class name can contain null bytes (https://3v4l.org/G91cW#v) so %pS is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant